[wp-trac] [WordPress Trac] #41104: Add "Site" to the "New" admin-bar dropdown

WordPress Trac noreply at wordpress.org
Sat Jun 26 21:32:18 UTC 2021


#41104: Add "Site" to the "New" admin-bar dropdown
-------------------------------------+------------------------------
 Reporter:  johnjamesjacoby          |       Owner:  (none)
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Toolbar                  |     Version:  3.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  multisite
-------------------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:  2nd-opinion close => has-patch needs-testing
 * status:  closed => reopened
 * resolution:  duplicate =>
 * milestone:   => Awaiting Review


Comment:

 OK, it would have been better to close the other ticket as duplicate.

 I don't know what else would go into a secondary menu group, so I simply
 iterated on @henry.wright's patch
 [https://core.trac.wordpress.org/attachment/ticket/49040/49040.diff
 49040.diff]:

 - Changing the link reference to `network_admin_url( 'site-new.php' )`, as
 it is in the dashboard widget
 - Moving this additional link outside the foreach loop
 - Moving `is_multisite()` before the capabilities check, to follow the
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/admin-
 bar.php?rev=50834#L385 'Edit Site' link] example
 - Editing the ID to 'add-new-site' to avoid confusion with
 [https://wpdirectory.net/search/01F90NDEG95FHJX3EEM6XWBQE6 Jetpack's 'new-
 site' link]
 - Adding to the DocBlock

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41104#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list