[wp-trac] [WordPress Trac] #52482: Tests: Reduce usage of assertEquals() for 5.8
WordPress Trac
noreply at wordpress.org
Thu Jun 24 06:52:09 UTC 2021
#52482: Tests: Reduce usage of assertEquals() for 5.8
-----------------------------------+-----------------------------
Reporter: johnbillion | Owner: SergeyBiryukov
Type: task (blessed) | Status: closed
Priority: normal | Milestone: 5.8
Component: Build/Test Tools | Version:
Severity: normal | Resolution: fixed
Keywords: needs-unit-tests php8 | Focuses:
-----------------------------------+-----------------------------
Comment (by SergeyBiryukov):
In [changeset:"51225" 51225]:
{{{
#!CommitTicketReference repository="" revision="51225"
Tests: Use `assertSame()` in `_wp_to_kebab_case()` tests.
This ensures that not only the return values match the expected results,
but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should
generally be preferred to `assertEquals()` where appropriate, to make the
tests more reliable.
Follow-up to [51079], [51198].
See #52482, #52625, #53397.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52482#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list