[wp-trac] [WordPress Trac] #53424: remove_theme_support doesn't restore back to classic widgets editor

[WordPress Trac]

#53424: remove_theme_support doesn't restore back to classic widgets editor
------------------------------+-------------------------
 Reporter:  kevin940726       |       Owner:  noisysocks
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  5.8
Component:  Widgets           |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch => has-patch commit


Comment:

 Reviewing the bundled themes:

 - `add_theme_support()` is wired to `'after_setup_theme'`
 - `'widgets_init'` is used for registering sidebars

 I agree with @audrasjb. The approach in [https://github.com/WordPress
 /wordpress-develop/pull/1382 PR 1382] is consistent with how themes handle
 adding theme support vs how they handle registering sidebars.

 Though this is dealing with adding theme support for the widgets block
 editor, it is a theme support. Having it hooked into `'after_setup_theme'`
 keeps it consistent. The advantage here is consistency to help theme
 authors.

 I've approved the PR. Marking this ticket for `commit`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53424#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform