[wp-trac] [WordPress Trac] #53410: Provide better guidance for users looking to test FSE themes
WordPress Trac
noreply at wordpress.org
Tue Jun 22 02:48:28 UTC 2021
#53410: Provide better guidance for users looking to test FSE themes
----------------------------------------------+-----------------------
Reporter: desrosj | Owner: desrosj
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.8
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: has-screenshots has-patch commit | Focuses:
----------------------------------------------+-----------------------
Changes (by desrosj):
* keywords: has-screenshots has-patch => has-screenshots has-patch commit
Comment:
Thanks for that review @marybaum. Sorry if any of the information I've
shared was misleading, but we're not looking to standardize the errors
shown on the front end as they're defined on a per theme basis. It would
be great for there to be one, consistent notice, but that's outside the
scope of this ticket. We're looking to add a protective measure to avoid
encountering those notices when possible.
Here we're mainly concerned with the warnings shown in [attachment
:"activate-error.png"] and [attachment:"plugin-screen.png"].
I've been thinking it over a bit and and discussed with @chanthaboune. For
the first one, we're going with "Error: This theme (TT1 Blocks) uses Full
Site Editing, which requires the Gutenberg plugin to be activated."
> New: Gutenberg is required for your theme to work correctly.
Deactivating it could disable parts of your site.
There are some other strings in Core using "your" but it feels a bit
strange to me in general as the user viewing the notice may not always be
the person that actually owns the site. The phrasing we've decided on for
this warning is "This plugin is required for the active theme to work
correctly. Deactivating is not recommended." I've opened
[https://github.com/WordPress/gutenberg/pull/32873 a PR on GitHub for this
one], as the best place to put this is in the plugin itself.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53410#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list