[wp-trac] [WordPress Trac] #53410: Provide better guidance for users looking to test FSE themes

WordPress Trac noreply at wordpress.org
Mon Jun 21 21:36:02 UTC 2021


#53410: Provide better guidance for users looking to test FSE themes
---------------------------------------+-----------------------
 Reporter:  desrosj                    |       Owner:  desrosj
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.8
Component:  Themes                     |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------

Comment (by marybaum):

 Replying to [comment:5 desrosj]:

 Okey dokey.

 Here's some updated text for the strings in the screenshots and patches
 below. If our style really requires the removal of hyphens in compound
 modifiers, go for it — I can't yet make myself do that.

 There are two versions of the message about FSE themes:

 "This theme is built to help test ..." and "This theme requires Gutenberg
 ..."

 With the Block-Based Bosco theme, I took a look down the road to a time
 when FSE is less experimental, and wrote the message accordingly. For now,
 the message should take the language about FSE being experimental.

 The first and last messages are identical, so the edits are identical.
 Other edits give us a chance to let folx know that playing with carries
 risk.

 So ....

 —————

 Old: This theme was built for the WordPress experimental full-site editing
 feature. You need to install and activate the Gutenberg plugin to make it
 work.

 New: This theme is built to test Full-Site Editing, an experimental
 WordPress feature. It will only work if you install and activate the
 Gutenberg plugin.

 ———————

 Old: This theme requires the Gutenberg plugin installed. Please visit your
 dashboard and follow the instructions on the notification displayed to
 enable the plugin and the Full Site Editing experiment.


 New: This theme  is built for an experimental feature called Full-Site
 Editing and requires the Gutenberg plugin, which must be both installed
 and active.

 To help test that feature, please visit your dashboard and follow the
 instructions for enabling Gutenberg.
 ———————--

 Old: Block-Based Bosco is a Full-Site Editing theme, which requires the
 Gutenberg plugin.

 New: Block-Based Bosco is a Full-Site Editing theme that required the
 Gutenberg plugin.

 (Note: This is copy for down the road. For now, the theme should carry one
 of the experimental-use messages.)
 ———--

 Old: Gutenberg is required for your theme to work correctly. Deactivating
 is not recommended.

 New: Gutenberg is required for your theme to work correctly. Deactivating
 it could disable parts of your site.

 ————

 Old: This theme was built for the WordPress experimental full-site editing
 feature. You need to install and activate the Gutenberg plugin to make it
 work.

 New: See NEW above.


 > [attachment:"53410.diff"] is a proof of concept that adds a check for
 the `full-site-editing` tag in the theme's `style.css` file. With this
 patch:
 > - A user can preview the theme in the Customizer, but they are not
 allowed to activate it unless Gutenberg is active.
 > - Clicking activate in the admin throws a `WP_Error` displays on a
 `wp_die()` screen.
 >
 > The error message displayed is very basic right now, but I envisioned an
 "Activate anyway" button, and potentially linking out to a page on .org
 explaining traditional themes vs. FSE themes.
 >
 > [attachment:"plugin-screen.png"] shows what I have in mind for the
 plugin screen. Deactivating Gutenberg will not be blocked, but a notice
 can be added to point out that the plugin is required for the current
 theme. This could and should probably be added to the plugin itself (the
 action hooks needed are already present in Core).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53410#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list