[wp-trac] [WordPress Trac] #33388: WP_Theme should use get_file_data() for retrieving page templates

WordPress Trac noreply at wordpress.org
Fri Jun 18 14:08:37 UTC 2021


#33388: WP_Theme should use get_file_data() for retrieving page templates
-------------------------------------+-----------------------------
 Reporter:  dd32                     |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.9
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:
-------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-testing close => needs-testing has-patch
 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * milestone:  Awaiting Review => 5.9


Comment:

 Replying to [comment:3 joyously]:
 > This ticket proposes a "should", but says it is not backward compatible.
 So why "should" it be changed?

 The backward compatibility concerns are addressed in [51182] / #33387, so
 this can now be addressed as well.

 Why? Using an existing function instead of partially duplicating its
 functionality should make future maintenance easier.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/33388#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list