[wp-trac] [WordPress Trac] #39265: Missing @covers in the comment blocks in PHPUnit tests

WordPress Trac noreply at wordpress.org
Wed Jun 16 23:01:26 UTC 2021


#39265: Missing @covers in the comment blocks in PHPUnit tests
-------------------------------------------+-----------------------------
 Reporter:  pbearne                        |       Owner:  hellofromTonya
     Type:  task (blessed)                 |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.8
Component:  Build/Test Tools               |     Version:  4.8
 Severity:  normal                         |  Resolution:
 Keywords:  php8 has-patch has-unit-tests  |     Focuses:
-------------------------------------------+-----------------------------

Comment (by hellofromTonya):

 In doing a deep and thorough review of PR 1255, it's huge with currently
 570 files changed. Tackling one big commit will be too big of an ask of a
 core committer. To reduce the impact on core committers and thus get the
 changes committed, @pbearne and I discussed and decided to the following
 process:

 - I'll do the thorough code review of a batch of files from PR 1255
 - If there are changes requested, Paul will update the branch
 - Then one of us will create a "batch patch"
 - Then the `commit` keyword will be added for a core committer to review
 and commit
 - Once committed, the changes will merged into the PR's branch

 Batch-by-batch the PR will get thoroughly reviewed and committed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39265#comment:65>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list