[wp-trac] [WordPress Trac] #24442: Visit theme/plugin/author homepage vs Visit theme/plugin/author site
WordPress Trac
noreply at wordpress.org
Sat Jun 12 19:52:59 UTC 2021
#24442: Visit theme/plugin/author homepage vs Visit theme/plugin/author site
----------------------------+-------------------------------------
Reporter: zeo | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: accessibility, ui-copy
----------------------------+-------------------------------------
Changes (by sabernhardt):
* keywords: dev-feedback i18n-change => has-patch
* focuses: ui-copy => accessibility, ui-copy
* component: Upgrade/Install => Administration
* milestone: => Awaiting Review
Old description:
> See:
>
> 1) http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-
> wp-ms-themes-list-table.php#L334: '''Visit theme homepage''' and '''Visit
> Theme Site'''
>
> 2) http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-
> wp-plugins-list-table.php#L418: '''Visit plugin site''' (2 same strings)
>
> 3) http://core.trac.wordpress.org/browser/trunk/wp-
> admin/includes/plugin.php#L160: '''Visit plugin homepage'''
>
> 4) http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-
> wp-plugins-list-table.php#L414,
> http://core.trac.wordpress.org/browser/trunk/wp-
> admin/includes/plugin.php#L163,
> http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-
> theme.php#L654: '''Visit author homepage'''
>
> These strings should be consistent but I'm not sure whether to go with
> '''site''' or '''homepage'''. I also suggest remove the redundant
> {{{title}}} attribute in 2).
>
> FYI, the strings only appear in the files that listed above.
New description:
See:
1) [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-
wp-ms-themes-list-table.php?rev=24379#L334 wp-admin/includes/class-wp-ms-
themes-list-table.php]: '''Visit theme homepage''' and '''Visit Theme
Site'''
2) [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-
wp-plugins-list-table.php?rev=24379#L418 wp-admin/includes/class-wp-
plugins-list-table.php]: '''Visit plugin site''' (2 same strings)
3) [https://core.trac.wordpress.org/browser/trunk/wp-
admin/includes/plugin.php?rev=24379#L160 wp-admin/includes/plugin.php]:
'''Visit plugin homepage'''
4) [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-
wp-plugins-list-table.php?rev=24379#L414 wp-admin/includes/class-wp-
plugins-list-table.php], [https://core.trac.wordpress.org/browser/trunk
/wp-admin/includes/plugin.php?rev=24379#L163 wp-
admin/includes/plugin.php], [https://core.trac.wordpress.org/browser/trunk
/wp-includes/class-wp-theme.php?rev=24379#L655 wp-includes/class-wp-
theme.php]: '''Visit author homepage'''
These strings should be consistent but I'm not sure whether to go with
'''site''' or '''homepage'''. I also suggest remove the redundant
{{{title}}} attribute in 2).
FYI, the strings only appear in the files that listed above.
--
Comment:
Updates:
- In changeset:28673 (ticket:26554), the title attributes were removed
from class-wp-plugins-list-table.php, plugin.php and class-wp-theme.php.
- Then changeset:35924 replaced the title attribute in class-wp-ms-themes-
list-table.php with an ARIA label of "Visit [theme name] homepage" for
context within a list of links.
That `aria-label` might be better as "Visit theme site for [theme name]"
so its beginning matches the visible link text (at least in English).
[attachment:"24442.diff"] edits the theme site link label (network themes
admin screen), and it adds a similar label on the plugin URI link when the
plugin is outside the directory.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/24442#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list