[wp-trac] [WordPress Trac] #44118: WordPress performs some unnecessary plugin update checks

[WordPress Trac]

#44118: WordPress performs some unnecessary plugin update checks
-------------------------------------+-----------------------------
 Reporter:  siliconforks             |       Owner:  francina
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------

Comment (by francina):

 I tested the patch today

 - MacOS 11.4
 - Safari 16611.2.7.1.4
 - wordpress-develop
 - WordPress 5.8-beta1-51132-src

 I can reproduce the issues, but the patch doesn't apply. This is the
 result I get


 {{{
 Hunk #1 succeeded at 151 with fuzz 1 (offset -145 lines).
 Hunk #2 FAILED at 182.
 Hunk #3 succeeded at 424 with fuzz 1 (offset 8 lines).
 1 out of 3 hunks FAILED -- saving rejects to file src/wp-
 includes/update.php.rej
 }}}


 And here is what I have in the file:

 {{{
 *** 179,184 ****
                 $plugin_changed = false;

                 foreach ( $plugins as $file => $p ) {
                         if ( ! isset( $current->checked[ $file ] ) ||
 (string) $current->checked[ $file ] !== (string) $p['Version'] ) {
                                 $plugin_changed = true;
                         }
 --- 182,189 ----
                 $plugin_changed = false;

                 foreach ( $plugins as $file => $p ) {
 +                       $new_option->checked[ $file ] = $p['Version'];
 +
                         if ( ! isset( $current->checked[ $file ] ) ||
 (string) $current->checked[ $file ] !== (string) $p['Version'] ) {
                                 $plugin_changed = true;
                         }

 }}}

 I think the patch needs a refresh :) Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44118#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform