[wp-trac] [WordPress Trac] #52482: Tests: Reduce usage of assertEquals() for 5.8

WordPress Trac noreply at wordpress.org
Thu Jun 10 20:37:24 UTC 2021


#52482: Tests: Reduce usage of assertEquals() for 5.8
-----------------------------------+-----------------------------
 Reporter:  johnbillion            |       Owner:  SergeyBiryukov
     Type:  task (blessed)         |      Status:  closed
 Priority:  normal                 |   Milestone:  5.8
Component:  Build/Test Tools       |     Version:
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  needs-unit-tests php8  |     Focuses:
-----------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"51137" 51137]:

 Tests: Use `assertSameSets()` in some newly introduced tests.

 This ensures that not only the array values being compared are equal, but
 also that their type is the same.

 Going forward, stricter type checking by using `assertSameSets()` or
 `assertSameSetsWithIndex()` should generally be preferred, to make the
 tests more reliable.

 Follow-up to [48939], [49925], [50157], [50959], [50960], [50995],
 [51079].

 See #52625, #52482.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52482#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list