[wp-trac] [WordPress Trac] #51754: Add a copy-link button at the media upload page
WordPress Trac
noreply at wordpress.org
Thu Jun 10 16:41:56 UTC 2021
#51754: Add a copy-link button at the media upload page
-------------------------------------------------+-------------------------
Reporter: anotia | Owner: antpb
Type: feature request | Status: reopened
Priority: normal | Milestone: 5.8
Component: Media | Version: 5.5.2
Severity: normal | Resolution:
Keywords: has-screenshots has-patch needs- | Focuses: ui,
codex needs-testing | accessibility
-------------------------------------------------+-------------------------
Changes (by sabernhardt):
* keywords: has-screenshots needs-design has-patch needs-codex => has-
screenshots has-patch needs-codex needs-testing
Comment:
If the error message is the only container that would show as one column
within the `media-item` container, `grid-column-start` and `grid-column-
end` in [attachment:"51754.8.diff"] could fix that. If there are any other
elements that need to span the full width, this probably would need a new
container div inside `media-item` for applying CSS grid.
On smaller screens, multiple-column layout does not work well, so the
patch proposes switching to one column. For longer translations, I used
the 600px breakpoint instead of 480. This can result in significant white
space when both the file name and the button translation are short in the
500-600 pixel range, yet that should be better than allowing the button to
overlap the file name within that range.
I also considered switching from grid to flex with flex-wrap, but flex-
wrap is not a good option.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51754#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list