[wp-trac] [WordPress Trac] #50105: Remove infinite scrolling behavior from the Media grid

[WordPress Trac]

#50105: Remove infinite scrolling behavior from the Media grid
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.8
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots needs-   |     Focuses:  ui, accessibility,
  dev-note 2nd-opinion needs-        |  javascript
  testing                            |
-------------------------------------+-------------------------------------
Changes (by adamsilverstein):

 * keywords:  has-screenshots needs-dev-note 2nd-opinion => has-screenshots
     needs-dev-note 2nd-opinion needs-testing


Comment:

 @spacedmonkey can you confirm the latest patch fixes your use case in the
 Unsplash plugin?

 @johnbillion in the latest patch, i reverted the ajax callback data return
 shape so that it should match what existed in 5.7, putting the post and
 page count information in the header as you suggested. Can you confirm
 this would restore compatibility for Asset Manager Framework?

 @joedolson Can you please review the latest patch and give it a test? This
 biggest change is [https://github.com/WordPress/wordpress-
 develop/pull/1335/files#diff-
 a157722401459b9143dd6fd997f65bb0f20f4734d79e24fe2099e9bedee256d2L118-R118
 setting the xhr as context] so we have access to the headers. I also wound
 up changing how the spinner hiding is handled to fix the behavior.

 Once we confirm this works well we should commit before beta 2 to get
 wider testing, especially with potentially affected plugins.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50105#comment:105>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform