[wp-trac] [WordPress Trac] #31521: wp_title if archive of year w/o permalink fires php notice in locale.php

[WordPress Trac]

#31521: wp_title if archive of year w/o permalink fires php notice in locale.php
-------------------------------------------------+-------------------------
 Reporter:  michelwppi                           |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:  4.1.1
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch has-        |     Focuses:  template
  screenshots needs-testing needs-unit-tests     |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  good-first-bug has-patch has-screenshots commit =>
     good-first-bug has-patch has-screenshots needs-testing needs-unit-
     tests
 * owner:  antpb => hellofromTonya
 * milestone:  5.8 => 5.9


Comment:

 In reviewing the patch, noticed it is using `substr()` and does not have
 guarding to check for failed state. In PHP 8, `substr()` return type
 changed for failure from boolean `false` to an `''` empty string. This
 change could have impact on the patch or upstream from it.

 Today is 5.8 Beta 1. After discussing with @antpb, decided to punt to 5.9
 to give time for deeper review and adding tests.

 Reassigning ownership to me to follow-up on the review and tests.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/31521#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform