[wp-trac] [WordPress Trac] #53138: Convert special HTML entities in characters in widgets descriptions
WordPress Trac
noreply at wordpress.org
Tue Jun 8 22:42:20 UTC 2021
#53138: Convert special HTML entities in characters in widgets descriptions
------------------------------+-----------------------
Reporter: justinahinon | Owner: audrasjb
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.8
Component: Widgets | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+-----------------------
Changes (by SergeyBiryukov):
* status: closed => reopened
* resolution: fixed =>
Comment:
Thanks for the patch! However, I don't think [51114] is the correct
approach here:
* It does not account for translations. These four widgets are just the
ones that have entities in their English description, translations may add
or remove entities, so decoding them only for some of the widgets is not a
consistent solution.
* It does not account for custom widgets. Any custom widgets that have
entities in their description would still run into the same issue.
If the block editor displays these descriptions somewhere without decoding
entities first, it should be fixed there, on display, consistently for all
widgets, and not in the individual widgets' constructors. So I would
recommend reverting [51114] for now.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53138#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list