[wp-trac] [WordPress Trac] #51189: comments_pagination_base missing in get_comment_reply_link() function
WordPress Trac
noreply at wordpress.org
Mon Jun 7 20:17:25 UTC 2021
#51189: comments_pagination_base missing in get_comment_reply_link() function
-------------------------------------------------+-------------------------
Reporter: MrPauloEn | Owner: joedolson
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.8
Component: Comments | Version: 5.5
Severity: normal | Resolution:
Keywords: has-screenshots good-first-bug has- | Focuses:
patch has-testing-info commit | accessibility
-------------------------------------------------+-------------------------
Comment (by joedolson):
No, I don't think that's a concern. The link that `get_comment_link()`
will produce for the comment is a more permanent link; you'll always be
able to find it there barring changes to the pagination settings. The
other link is not permanent, as adding additional comments could push it
off the front page.
`get_comment_link()` is the correct way to produce a comment link, and I
don't think we should attempt to determine whether a given comment should
currently be on the front page.
The SEO concerns should be nominal, given that this link is overridden
with JavaScript in normal usage & WordPress provides canonical URL
references.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51189#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list