[wp-trac] [WordPress Trac] #48222: "Show password" button overlaps with the LastPass icon

[WordPress Trac]

#48222: "Show password" button overlaps with the LastPass icon
-----------------------------------------------------+---------------------
 Reporter:  SergeyBiryukov                           |       Owner:  (none)
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  5.8
Component:  Login and Registration                   |     Version:  5.3
 Severity:  normal                                   |  Resolution:
 Keywords:  has-screenshots has-patch needs-testing  |     Focuses:  ui
-----------------------------------------------------+---------------------
Changes (by sabernhardt):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch needs-
     testing


Comment:

 Changes in [attachment:"48222.8.diff"]:

 - The password visibility button needs to keep the focus outline (the
 change in color is insufficient).
 - A small amount of padding (2px) is on both the left and right sides of
 the button for better readability with the focus outline.
 - The button has additional margin on the top and bottom so it does not
 touch either the input or the submit button. The click target itself is
 still 30 pixels tall, though the spacing around it adds 16 more.
 - The aria-label is removed because the button text gives that information
 already.
 - The password input does not have the side padding anymore, which had
 made room for the button in front of it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48222#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform