[wp-trac] [WordPress Trac] #53334: Update Requests library to version 1.8.1

WordPress Trac noreply at wordpress.org
Sun Jun 6 13:41:40 UTC 2021


#53334: Update Requests library to version 1.8.1
--------------------------------+---------------------
 Reporter:  jrf                 |       Owner:  (none)
     Type:  task (blessed)      |      Status:  new
 Priority:  normal              |   Milestone:  5.8
Component:  External Libraries  |     Version:  trunk
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:
--------------------------------+---------------------

Comment (by SergeyBiryukov):

 It also looks like this line should not be removed from
 `Requests/Utility/FilteredIterator.php`:
 {{{
 @phpcs:disable
 PHPCompatibility.FunctionNameRestrictions.ReservedFunctionNames.MethodDoubleUnderscore
 }}}

 Removing that causes the [https://github.com/SergeyBiryukov/wordpress-
 develop/runs/2757425743?check_suite_focus=true PHP compatibility task] to
 fail:
 {{{
 Run phpcs --standard=phpcompat.xml.dist -q --report=checkstyle | cs2pr
 Warning: Method name "Requests_Utility_FilteredIterator::__unserialize" is
 discouraged; PHP has reserved all method names with a double underscore
 prefix for future use.
 Error: Process completed with exit code 1.
 }}}

 This should probably be reported upstream. cc @jrf

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53334#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list