[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------+-----------------------------
 Reporter:  pbiron             |       Owner:  pbiron
     Type:  enhancement        |      Status:  reopened
 Priority:  normal             |   Milestone:  Future Release
Component:  Upgrade/Install    |     Version:
 Severity:  normal             |  Resolution:
 Keywords:  early needs-patch  |     Focuses:
-------------------------------+-----------------------------

Comment (by galbaras):

 Looks like this ticket is getting so long that we just look at the tail
 end of it. Thank you @SergeyBiryukov for clarifying.

 @afragen Given the preferred direction, the only failure scenarios I see
 are when WP fails to delete the existing directory or move the temporary
 directory to the live one, likely due to insufficient permissions, which
 should almost never happen.

 An even rarer case is when part of the directory is deleted/moved, and
 some fails to be deleted/moved.

 In the entire deletion fails, WP should return `false` (with some
 meaningful message), but at least the old plugin is still there. If only
 some of the deletion fails, or the move fails (partly or completely), WP
 may be crippled, but rolling back may suffer the same fate :(

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:93>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform