[wp-trac] [WordPress Trac] #52852: Update Twemoji for 5.8
WordPress Trac
noreply at wordpress.org
Tue Jun 1 13:31:51 UTC 2021
#52852: Update Twemoji for 5.8
---------------------------------------------+-----------------------
Reporter: desrosj | Owner: (none)
Type: enhancement | Status: reopened
Priority: normal | Milestone: 5.8
Component: Emoji | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses:
---------------------------------------------+-----------------------
Changes (by desrosj):
* keywords: has-patch has-unit-tests => has-patch has-unit-tests commit
Comment:
> What do y'all think about continuing to use the 13.0.1 folder or
switching to a new 13.1.0?
I think it may be best to introduce a new `13.1.0` folder on the CDN.
While the syringe did change quite a bit, I felt it was OK to push out
because, in my opinion, it would have a potentially positive impact.
That said, all of the other updates in `13.0.2` were relatively minor, and
no new Emoji were introduced. Any time new emoji are introduced, it's
probably best to have a new folder.
> Aside: I'm not sure if this counts as a feature change (and thus too
late for 5.8) or not.
There are probably sensible arguments for both sides of this. I think it's
reasonable to include this update. The messaging would become pretty
confusing if we need to say "Twemoji was updated, but only to `13.0.2`,
and `13.1.0` will be included in the next release." It's more clear to
just say "updated to the latest version."
Also, since we're creating a new folder on the CDN, it won't be possible
to push further minor refinements (should they happen) to users until 5.9
is released if this update is not included.
Your PR looks good to me @kraftbj! Happy to commit it once we're able to
push the new folder to the CDN.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52852#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list