[wp-trac] [WordPress Trac] #53738: Broken loop in WP_Theme_JSON_Resolver

WordPress Trac noreply at wordpress.org
Fri Jul 30 12:20:52 UTC 2021


#53738: Broken loop in WP_Theme_JSON_Resolver
--------------------------+----------------------
 Reporter:  schlessera    |       Owner:  desrosj
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  5.8.1
Component:  Themes        |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  fixed-major   |     Focuses:
--------------------------+----------------------
Changes (by desrosj):

 * owner:  (none) => desrosj
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"51515" 51515]:
 {{{
 #!CommitTicketReference repository="" revision="51515"
 I18n: Fix broken loop in `WP_Theme_JSON_Resolver`

 Related issue in Gutenberg:
 https://github.com/WordPress/gutenberg/issues/33552.

 The loop in `WP_Theme_JSON_Resolver` to extract translatable paths was
 broken, as it contained an immediate and unconditional return. This caused
 the loop to immediately exit again after the first iteration, thus never
 actually looping.

 Follow-up to [50959].

 Props schlessera.
 Merges [51472] to the 5.8 branch.
 Fixes #53738.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53738#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list