[wp-trac] [WordPress Trac] #53770: Site logo missing in 5.8

[WordPress Trac]

#53770: Site logo missing in 5.8
------------------------------------------------+--------------------------
 Reporter:  eqwmo                               |       Owner:  (none)
     Type:  defect (bug)                        |      Status:  new
 Priority:  normal                              |   Milestone:  Awaiting
                                                |  Review
Component:  Customize                           |     Version:  5.8
 Severity:  normal                              |  Resolution:
 Keywords:  has-testing-info reporter-feedback  |     Focuses:
------------------------------------------------+--------------------------
Changes (by hellofromTonya):

 * keywords:  has-testing-info => has-testing-info reporter-feedback


Comment:

 Replying to [comment:5 eqwmo]:
 > 3. No plugins have changed since the upgrade to WP 5.8. If it is caused
 by a plugin conflict, it is new with 5.8 and caused by the core upgrade
 not the plugin. There are no plugins that would remove the logo element
 from the generated HTML prior to generating or serving the page. The issue
 is that 5.8 and/or Jetpack is not generating that element. (Note: the
 site-branding"container div is generated, it should contain two visual
 items being the site-logo and site-name, the site-logo is missing from the
 DOM but the site-name is being generated just fine).

 @eqwmo Though no other plugins were upgraded or added, a plugin can have a
 conflict with a new version of WordPress, a theme, or another plugin. We
 were able to reproduce the Customizer previewer not showing the logo but
 it did properly render on the front-end and saved in the database. Testing
 is only with Jetpack version 9.9.1 and Goran theme version 1.2.5. No other
 plugins were activated.

 Deactivating all of your plugins, except for Jetpack, will help
 contributors and you to further investigate what could be causing the
 problem.

 > Interestingly, could the issues discovered by @jokanane be contributing?
 If `get_theme_mod('custom_logo')` is returning something different in 5.8
 to what it used to in the previous version, there could be a big chance
 that this could be the cause of my issue too.

 The Goran theme does not use or have a `custom_logo` mod in its
 `theme_mods_goran` option in the database:

 {{{
 a:5:{i:0;b:0;s:18:"nav_menu_locations";a:1:{s:7:"primary";i:2;}s:18:"custom_css_post_id";i:-1;s:16:"header_textcolor";s:6:"ffffff";s:16:"sidebars_widgets";a:2:{s:4:"time";i:1627414470;s:4:"data";a:8:{s:19:"wp_inactive_widgets";a:0:{}s:9:"sidebar-1";a:1:{i:0;s:13:"custom_html-2";}s:9:"sidebar-2";a:0:{}s:9:"sidebar-3";a:0:{}s:9:"sidebar-4";a:0:{}s:9:"sidebar-5";a:0:{}s:9:"sidebar-6";a:0:{}s:9:"sidebar-7";a:0:{}}}}
 }}}

 Rather, it uses Jetpack. Jetpack saves to the `site_option` in the
 database. When rendering, it checks if the current theme has a
 `custom_logo` mod (which Goran does not) and if no, it uses the
 `site_logo` option. In testing, the `site_logo` option updated correctly
 each time.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53770#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform