[wp-trac] [WordPress Trac] #53770: Site logo missing in 5.8

[WordPress Trac]

#53770: Site logo missing in 5.8
------------------------------+------------------------------
 Reporter:  eqwmo             |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Customize         |     Version:  5.8
 Severity:  normal            |  Resolution:
 Keywords:  has-testing-info  |     Focuses:
------------------------------+------------------------------

Comment (by hellofromTonya):

 == Test Report 2

 The test team worked live on this today during
 [https://youtu.be/16WPs9Bzg9g live stream].

 === Testing Environment

 WordPress: 5.7.2 and 5.8.0
 All activated plugins: Jetpack (needed to add the site logo field)
 Theme: Goran
 Localhost: Local running on nginx, PHP 7.3.5, MySQL 8.0.16
 OS: macOS Big Sur v 11.5
 Browser: Chrome v 92.0.4515.107

 === Testing Steps

 - Add a logo to `Appearance` > `Customize` > `Site Identity` > `Logo`
 - Click the `Publish` button.
 - Check if the logo renders in the logo field, Customizer previewer, and
 front-end. Results: Yes, rendered in all 3 ✅
 - Check the `site_logo` option in the `wp_options` database table.
 Results: ✅
 - Click `Remove logo` button.
 - Click the `Publish` button.
 - Recheck rendering. **Results**: Logo is gone in all 3 places ✅
 - Check the `site_logo` option in the `wp_options` database table.
 Results: ID = 0 ✅
 - Add a different logo.
 - Click the `Publish` button.
 - Recheck rendering. **Results**: Logo does not render in Customizer
 previewer ❌ but does render in the field and front-end
 - Check the `site_logo` option in the `wp_options` database table.
 Results: ✅
 - Switch to 5.8.0
 - Retest. Results: Same results as on WP 5.7.2

 - Switch to Twenty Twenty-One theme.
 - Retest. **Results**: Rendering correctly ✅ and could not reproduce
 problems seen above with Goran
 - Check the `theme_mods_twentytwentyone` option in the `wp_options`
 database table. **Results**: `custom_logo` was correctly updated ✅
 - Upgrade to WP 5.7.2
 - Retest. **Results**: Rendering correctly ✅
 - Check the `theme_mods_twentytwentyone` option in the `wp_options`
 database table. **Results**: `custom_logo` was correctly updated ✅

 - Switch to Twenty Twenty theme.
 - Retest. **Results**: Rendering correctly ✅ and could not reproduce
 problems seen above with Goran
 - Check the `theme_mods_twentytwenty` option in the `wp_options` database
 table. **Results**: `custom_logo` was correctly updated ✅
 - Upgrade to WP 5.8.0
 - Retest. **Results**: Rendering correctly ✅
 - Check the `theme_mods_twentytwenty` option in the `wp_options` database
 table. **Results**: `custom_logo` was correctly updated ✅

 - In all tests, there were no browser console errors or server side
 errors.

 === Testing Results

 - ❌ Able to reproduce logo not appearing in the Customizer previewer with
 Goran + Jetpack
    - ✅ Happens on both WordPress 5.7.2 and 5.8.0
    - ✅ Logo renders correctly in the settings field and on the front-end
    - ✅ Logo properly updates in the `site_option` option in the database

 - ✅ Not able reproduce the problem with Twenty Twenty or Twenty Twenty-
 One themes with and without Jetpack. These themes use their own theme mod
 and not the `site_logo` option.

 - ✅ No browser console errors

 - ✅ No server side errors (`error.log` is empty)

 === Testing Observations

 - ✅ Does not appear to be a WordPress 5.8 problem as it happens on 5.7.2
 too.

 - 👉 Likely suspect causing it: Jetpack plugin

 Goran uses Jetpack for the site logo. In the theme's `header.php` file,
 it's using `edin_the_site_logo()` from Jetpack:

 {{{#!php
 <div class="site-branding">
         <?php edin_the_site_logo(); ?>
         <h1 class="site-title"><a href="<?php echo esc_url( home_url( '/'
 ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
         <h2 class="site-description"><?php bloginfo( 'description' );
 ?></h2>
 </div><!-- .site-branding -->
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53770#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform