[wp-trac] [WordPress Trac] #40338: Twenty Seventeen: Layout broken and JS error in `wp-activate.php`
WordPress Trac
noreply at wordpress.org
Fri Jul 23 22:45:15 UTC 2021
#40338: Twenty Seventeen: Layout broken and JS error in `wp-activate.php`
-------------------------------------------------+-------------------------
Reporter: flixos90 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
| Review
Component: Bundled Theme | Version: 4.7
Severity: normal | Resolution:
Keywords: has-screenshots has-patch needs- | Focuses: multisite
testing |
-------------------------------------------------+-------------------------
Comment (by sabernhardt):
The forms touch the left edge in Twenty Nineteen and newer bundled themes,
too. I think the signup and activate pages should have centering for any
theme. A patch on #43536 adds the body class and centers the form.
[attachment:"40338.1.diff"] sets the signup form styles on the activate
page for Twenty Fourteen and includes the script change for Twenty
Seventeen.
If Twenty Seventeen should have the `wrap` container, that could be added
to special header and footer templates (header-wp-activate.php, etc.).
Another possibility is assigning the `wrap` max-width and padding to the
signup and activate containers in the Twenty Seventeen stylesheet. Also,
with the `is_home` value corrected on the other ticket, these pages would
not have the full-height header image.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40338#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list