[wp-trac] [WordPress Trac] #53729: $title never used, Replaced with text

WordPress Trac noreply at wordpress.org
Wed Jul 21 22:11:01 UTC 2021


#53729: $title never used, Replaced with text
-------------------------------------+-------------------------------
 Reporter:  ravipatel                |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Help/About               |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  coding-standards
-------------------------------------+-------------------------------
Changes (by audrasjb):

 * keywords:  has-patch => has-patch needs-refresh
 * component:  Administration => Help/About


Comment:

 Hello, thanks for the ticket and the patch.

 `_e()`  function is meant to display thing, so you shouldn't write `$title
 = _e( 'Privacy' );`.

 Plus, if the `$title` variable is never used, shouldn't we just get rid of
 it?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53729#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list