[wp-trac] [WordPress Trac] #52217: Fix code issues identified by PHPStan

[WordPress Trac]

#52217: Fix code issues identified by PHPStan
-------------------------+-------------------------------
 Reporter:  johnbillion  |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.9
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  coding-standards
-------------------------+-------------------------------

Comment (by hellofromTonya):

 Replying to [comment:13 johnbillion]:
 > This should not be a reason to discount introducing tooling that can
 identify bugs.

 I agree that it can help identify bugs, which is why we saw it as a good
 ad-hoc and auditing tool. I wonder if I might have misunderstand how this
 ticket is proposing it be used. So let me ask:

 @johnbillion Do you envision wiring PHPStan as another inline CI
 dependency like we do for running phpcs and phpunit?

 If yes:

 - How do we help contributors analyze incidents reported by it to
 determine if it's a real and fixable issue and then resolve each?
 - Do you foresee it becoming a pain point for contributors?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52217#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform