[wp-trac] [WordPress Trac] #53363: Test tool and unit test improvements for 5.9

WordPress Trac noreply at wordpress.org
Mon Jul 19 13:29:58 UTC 2021


#53363: Test tool and unit test improvements for 5.9
------------------------------+---------------------
 Reporter:  desrosj           |       Owner:  (none)
     Type:  task (blessed)    |      Status:  new
 Priority:  normal            |   Milestone:  5.9
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"51461" 51461]:
 {{{
 #!CommitTicketReference repository="" revision="51461"
 Tests: Use more appropriate assertions in various tests.

 This replaces instances of `assertFalse( stripos( ... ) )` with
 `assertStringNotContainsString()` or
 `assertStringNotContainsStringIgnoringCase()` to use native PHPUnit
 functionality.

 Going forward, these methods introduced in PHPUnit 7.5 should be used for
 similar assertions:

 * `assertStringContainsString()`
 * `assertStringContainsStringIgnoringCase()`
 * `assertStringNotContainsString()`
 * `assertStringNotContainsStringIgnoringCase()`

 As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6,
 polyfills for these methods are now added to the `WP_UnitTestCase` class
 for PHPUnit < 7.5.

 Follow-up to [51335], [51337], [51367], [51397], [51403], [51404],
 [51436], [51438], [51448], [51449], [51451], [51453], [51454].

 See #53363.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53363#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list