[wp-trac] [WordPress Trac] #53687: `grunt verify:old-files` incorrectly flagging certain files
WordPress Trac
noreply at wordpress.org
Mon Jul 19 01:53:28 UTC 2021
#53687: `grunt verify:old-files` incorrectly flagging certain files
------------------------------+---------------------------
Reporter: desrosj | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.8.1
Component: Build/Test Tools | Version: 5.7
Severity: normal | Keywords: needs-testing
Focuses: |
------------------------------+---------------------------
In [50441], a PHPUnit test that verified built files were not included in
the `$_old_files` list was moved into a Grunt task, `verify:old-files`.
For some reason, this is incorrectly flagging a few files that were
removed and should be included in this list for WordPress 5.8:
- `wp-includes/css/dist/editor/editor-styles.min.css`
- `wp-includes/css/dist/editor/editor-styles-rtl.css`
- `wp-includes/css/dist/editor/editor-styles-rtl.min.css`
- `wp-includes/css/dist/editor/editor-styles.css`
A build error is only encountered when running `build`, `build:dev` does
not result in an error.
It seems that the `-rtl` and `.min` parts of the file are the culprit
because `wp-includes/css/dist/editor/editor-styles.css` is not resulting
in the task failing.
I don't necessarily think that this is a blocker for WordPress 5.8. The
`$_old_files` list is run over for every update. So these files can be
added in 5.8.1 and they will be removed appropriately.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53687>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list