[wp-trac] [WordPress Trac] #53009: Tests: review all calls to markTestSkipped() and @requires annotations

WordPress Trac noreply at wordpress.org
Tue Jul 13 10:43:57 UTC 2021


#53009: Tests: review all calls to markTestSkipped() and @requires annotations
---------------------------------------------+-----------------------------
 Reporter:  jrf                              |       Owner:  hellofromTonya
     Type:  task (blessed)                   |      Status:  closed
 Priority:  normal                           |   Milestone:  5.9
Component:  Build/Test Tools                 |     Version:
 Severity:  minor                            |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  docs,
                                             |  performance
---------------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"51415" 51415]:
 {{{
 #!CommitTicketReference repository="" revision="51415"
 Tests: Clean up skipping conditions and requirements for various tests.

 This improves the consistency of test skipping and ensures that:

 * The `@requires` annotations use the right condition and format, and are
 on the right level (class vs. function).
 * Inline conditions with a `markTestSkipped()` call are only used when
 annotations cannot be used.
 * All `markTestSkipped()` calls contain a verbose explanation of why the
 test is being skipped.

 Props jrf, hellofromTonya.
 Fixes #53009.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53009#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list