[wp-trac] [WordPress Trac] #53123: Tests: review of assertTrue or assertFalse with in_array

WordPress Trac noreply at wordpress.org
Mon Jul 12 10:35:58 UTC 2021


#53123: Tests: review of assertTrue or assertFalse with in_array
------------------------------+-----------------------------
 Reporter:  hellofromTonya    |       Owner:  SergeyBiryukov
     Type:  task (blessed)    |      Status:  closed
 Priority:  normal            |   Milestone:  5.9
Component:  Build/Test Tools  |     Version:
 Severity:  minor             |  Resolution:  fixed
 Keywords:                    |     Focuses:  docs
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"51404" 51404]:
 {{{
 #!CommitTicketReference repository="" revision="51404"
 Tests: Use more appropriate assertions in various tests.

 This replaces instances of `assertTrue( in_array( ... ) )` with
 `assertContains()` to use native PHPUnit functionality.

 Follow-up to [51335], [51337], [51367], [51397], [51403].

 Props hellofromTonya, jrf, SergeyBiryukov.
 Fixes #53123. See #53363.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53123#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list