[wp-trac] [WordPress Trac] #44314: `user_confirmed_action_email_content` filter run on two different strings

[WordPress Trac]

#44314: `user_confirmed_action_email_content` filter run on two different strings
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  garrett-
                                                 |  eclipse
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.8
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note early commit                              |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Reopening for some minor cleanup:

 * There are some typos in filter descriptions: "an user", "when a their
 data".
 * Per the [https://developer.wordpress.org/coding-standards/inline-
 documentation-standards/php/#line-wrapping documentation standards],
 DocBlocks should preferably wrap to the next line after 80 characters or
 so, and should not extend beyond a total of 120 characters wide.
 * The deprecation message itself clearly states the suggested replacement,
 as seen on
 [https://developer.wordpress.org/reference/hooks/dbx_post_advanced/
 dbx_post_advanced] hook page, for example. I don't see a reason to
 duplicate this in the hook description, and it looks like we don't
 generally do that for other deprecated hooks. I think adding this to the
 `@deprecated` tag is sufficient.
 * I think the unneccessary indent adjument, along with the `phpcs:ignore`
 comment, can be removed. This is not really consistent with other similar
 emails in core on even in the same file. If someone feels strongly about
 removing extra tabs from the first lines here, let's do that consistently
 for all emails in a new ticket.

 See [attachment:"44314.10.diff"].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44314#comment:77>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform