[wp-trac] [WordPress Trac] #53593: The `permissions_check()` methods are missing the `$request` parameter

WordPress Trac noreply at wordpress.org
Tue Jul 6 15:55:16 UTC 2021


#53593: The `permissions_check()` methods are missing the `$request` parameter
-------------------------------------------------+-------------------------
 Reporter:  johnbillion                          |       Owner:  desrosj
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.8
Component:  REST API                             |     Version:  trunk
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed        |     Focuses:
  fixed-major                                    |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"51350" 51350]:
 {{{
 #!CommitTicketReference repository="" revision="51350"
 REST API: Add the `$request` parameter to methods checking permissions.

 This adds the `$request` parameter to the permissions_check() methods
 within `WP_REST_Widgets_Controller` and adds $request as an allowed
 parameter to the `permissions_check()` method within
 `WP_REST_Templates_Controller`.

 Even when this parameter is not used by default, it should be implemented
 to support the class being extended and the method overridden.

 Props johnbillion, timothyblynjacobs.
 Merges [51349] to the 5.8 branch.
 Fixes #53593.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53593#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list