[wp-trac] [WordPress Trac] #53576: Remove unnecessary compatibility shim added in 5.8

[WordPress Trac]

#53576: Remove unnecessary compatibility shim added in 5.8
--------------------------+---------------------
 Reporter:  desrosj       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.8
Component:  Themes        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by nosolosw):

 Hey, sorry about the late response. This code needs to remain, although
 the comment could be removed as it's a leftover.

 This is what I've tested:

 - Theme without `theme.json` support: the spacing panel is shown when the
 theme adds `add_theme_support( 'custom-spacing' );`, otherwise is not.

 - Theme with `theme.json` and `settings.spacing.customPadding` equals
 `true`: the spacing panel is shown, whether or not the theme has `custom-
 spacing` theme support.

 - Theme with `theme.json` and `settings.spacing.customPadding` equals
 `false`: the spacing panel is not shown, whether or not the theme has
 `custom-spacing` theme support.

 I've also tested that it can be enabled per block (disable the top-level
 `settings.spacing.customPadding` but enable it for the `core/cover` block,
 for example).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53576#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform