[wp-trac] [WordPress Trac] #51976: Core update footer displays incorrect message when on current release -- sometimes
WordPress Trac
noreply at wordpress.org
Sun Jan 31 18:09:08 UTC 2021
#51976: Core update footer displays incorrect message when on current release --
sometimes
----------------------------------------------+-----------------------
Reporter: afragen | Owner: afragen
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.7
Component: Upgrade/Install | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit | Focuses: ui
----------------------------------------------+-----------------------
Comment (by SergeyBiryukov):
Personally, I like the existing wording that implies that running a
development version is "cool" :) I think it adds a bit of personality, so
I'm not quite a fan of removing it.
Re-reading comment:2 and looking at the previous changes [49708] and
[49736], I think the only change needed here is to make sure the message
is really about the current `$wp_version` value and not about the API
response.
See [attachment:"51976.3.diff"]. This should address the concerns of
displaying an inaccurate message and would also be consistent with the
same message in [source:tags/5.6/src/wp-admin/update-
core.php?marks=237,252,253#L229 core_upgrade_preamble()] on WordPress
Updates screen.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51976#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list