[wp-trac] [WordPress Trac] #33717: Send Notification Email When a Comment is Approved From Moderation

[WordPress Trac]

#33717: Send Notification Email When a Comment is Approved From Moderation
---------------------------------------------+--------------------------
 Reporter:  jeffr0                           |       Owner:  johnbillion
     Type:  enhancement                      |      Status:  reviewing
 Priority:  normal                           |   Milestone:  5.7
Component:  Comments                         |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  needs-dev-note has-patch commit  |     Focuses:
---------------------------------------------+--------------------------
Changes (by johnbillion):

 * keywords:  needs-dev-note has-patch => needs-dev-note has-patch commit


Comment:

 [attachment:"33717.16.diff"] is one last tweak to this.

 * Removes the `$skip_backcompat` parameter from the the
 `comment_approval_notification_form()` as its value is always `true`. A
 custom walker would not need to call this method without disabling the
 backcompat output otherwise you get the form twice.
 * Renames the `$backcompat` property so it only deals with this specific
 form output instead of being an array. If we end up introducing other
 features like this that also need backcompat it's a bit easier to see when
 they were introduced if they're in individual properties.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/33717#comment:79>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform