[wp-trac] [WordPress Trac] #52342: Update copy_dir and _copy_dir for $dirlist error reporting

WordPress Trac noreply at wordpress.org
Fri Jan 29 02:08:13 UTC 2021


#52342: Update copy_dir and _copy_dir for $dirlist error reporting
-----------------------------+---------------------
 Reporter:  afragen          |       Owner:  (none)
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  5.7
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch early  |     Focuses:
-----------------------------+---------------------

Comment (by afragen):

 The reason for the $first_pass was I think dirlist() could be false with a
 empty directory. If that’s the case an empty subfolder could cause a
 WP_Error. I didn’t want to risk some dev putting in an empty folder.

 At least that was my initial logic. If I’m wrong then the check above is
 good.

 I’ll defer to your experience and expertise.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52342#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list