[wp-trac] [WordPress Trac] #52327: Requested updates to the PHP Update Alert
WordPress Trac
noreply at wordpress.org
Thu Jan 28 10:18:40 UTC 2021
#52327: Requested updates to the PHP Update Alert
-------------------------------------------+-----------------------
Reporter: chanthaboune | Owner: audrasjb
Type: defect (bug) | Status: reopened
Priority: high | Milestone: 5.6.1
Component: Site Health | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-reviewed commit | Focuses:
-------------------------------------------+-----------------------
Changes (by SergeyBiryukov):
* status: closed => reopened
* resolution: fixed =>
Comment:
Replying to [comment:6 Clorith]:
> The first message inside the dashboard widget is patched to read
> > Your site is running an outdated version of PHP (%s), which requires
an update.
>
> This should perhaps also be more aligned with recommendation over
required if that's the desired outcome here, for example:
> > Your site is running an outdated version of PHP (%s), and should be
updated.
This new wording seems ambiguous, to me it reads as "Your site ... should
be updated", and not the PHP version.
Could we replace "and should be updated" with "which should be updated"?
See [attachment:"52327.2.diff"].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52327#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list