[wp-trac] [WordPress Trac] #49889: Image.php - Wrap Error Suppressors in WP_DEBUG Conditionals

[WordPress Trac]

#49889: Image.php - Wrap Error Suppressors in WP_DEBUG Conditionals
--------------------------------------+-------------------------------
 Reporter:  Howdy_McGee               |       Owner:  SergeyBiryukov
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.7
Component:  Media                     |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch needs-dev-note  |     Focuses:  coding-standards
--------------------------------------+-------------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch needs-dev-note needs-unit-tests => has-patch needs-
     dev-note


Comment:

 Removing `needs-unit-tests` as PR 927 resolves the failing tests. How?
 When the tests are running, skips the unsilenced code, i.e. the for debug
 mode code, and uses the production code. Uses the same strategy in the
 REST API of checking `defined( 'DIR_TESTDATA' )`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49889#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform