[wp-trac] [WordPress Trac] #52365: includes/js/underscore.js missing var keyword on line 157

WordPress Trac noreply at wordpress.org
Mon Jan 25 21:49:58 UTC 2021


#52365: includes/js/underscore.js missing var keyword on line 157
-----------------------------------------+------------------------------
 Reporter:  Venutius                     |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  External Libraries           |     Version:  5.6
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |     Focuses:
-----------------------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch => has-patch reporter-feedback
 * component:  General => External Libraries


Comment:

 Hi there, welcome back to WordPress Trac! Thanks for the ticket.

 Just noting that there is `var i` a few lines above:
 https://build.trac.wordpress.org/browser/tags/5.6/wp-
 includes/js/underscore.js?marks=150#L142

 So it looks like the variable is already declared, and the suggested
 change would not make any difference.

 Could you provide the steps to reproduce the issue on a clean install?

 Please note that Undescore.js is an external library, any suggested
 changes should be submitted upstream:
 https://github.com/jashkenas/underscore

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52365#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list