[wp-trac] [WordPress Trac] #51812: Update jQuery step three

WordPress Trac noreply at wordpress.org
Mon Jan 25 13:51:13 UTC 2021


#51812: Update jQuery step three
-------------------------------------------------+-------------------------
 Reporter:  azaozz                               |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.7
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early needs-testing        |     Focuses:  javascript
  needs-dev-note                                 |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:36 Hareesh Pillai]:
 > While running the QUnit tests, I came across this warning -
 `jQuery.unique is deprecated; use jQuery.uniqueSort`. Upon checking,
 there's an instance of unique() method being used in
 [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/wp/customize/widgets.js?rev=50001#L1871
 customize-widgets.js]

 Just noting that the instance in `customize-widgets.js` appears to be a
 [https://underscorejs.org/#uniq function from Underscore.js] and looks
 correct as is. Changing it to `uniqueSort()` does not remove the warning
 in my testing.

 The only instances of `jQuery.unique()` I've found are from jQuery UI, so
 I think the warning comes from there.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51812#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list