[wp-trac] [WordPress Trac] #52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)

[WordPress Trac]

#52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)
--------------------------------------------+-----------------------
 Reporter:  desrosj                         |       Owner:  desrosj
     Type:  task (blessed)                  |      Status:  assigned
 Priority:  high                            |   Milestone:  5.7
Component:  Build/Test Tools                |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  needs-testing has-patch commit  |     Focuses:
--------------------------------------------+-----------------------
Changes (by netweb):

 * keywords:  needs-testing has-patch => needs-testing has-patch commit


Comment:

 Replying to [comment:27 desrosj]:
 > {{{#!comment
 > 765472388
 > }}}
 > [https://github.com/desrosj desrosj] commented on
 [https://github.com/WordPress/wordpress-
 develop/pull/885#issuecomment-765472388 PR #885]:
 >
 > For the images, I did run precommit:images and committed the changes in
 https://github.com/WordPress/wordpress-
 develop/pull/885/commits/fab68cdac95ef3c9f07f2c93e3516d9a4d514d9a for the
 5.5 branch.
 >
 > It looks like there is one image being "removed", but it's still
 technically there. The imagemin script just reduced it enough to be
 considered a 100% change in size. Thinking this over more, though, the
 image changes are not required. The script should be confirmed as working,
 but we can exclude the resulting changes from this PR in order to limit
 the number of files changed in each branch.

 Ah, that's what I missed, I didn't look close enough 👍🏼




 Replying to [comment:28 desrosj]:
 > I've removed all image changes from every branch. This cut down the
 number of files changed by between 30-70, depending on the branch.


 Yes, this looks good, this will help the autoupdate process and keep those
 distribution packages
 a little smaller, and in particular less files 👍🏼


 Replying to [comment:28 desrosj]:
 > Additionally, I discovered that some files in the 5.x branches were
 changed unnecessarily. Somehow, the versions of nested dependencies were
 updated in the lock file and this caused Gutenberg dependencies to change.
 I've fixed this in those branches, and updated the associated build PR.

 Again, looks good 👍🏼

 Aside, in a future release we could update some of these additional
 webpack and Gutenberg dependencies and ship these minified images, CSS
 changes, JS changes in future releases, for example ship CSS change in
 `5.0.13`, JS changes in `5.0.14`, minified images in `5.0.15` to keep the
 number of changes files per release to a minimum, it's a little painful
 for sure, but in the end we would have a consistent set of packages, and
 it's not like we haven't been releasing new releases of the 3.7.x branch
 for 7 years 😉

 ----

 Overall looks good to me for the 5.0-5.5 branches, I've still not looked
 at the older branches, but the concept should be the same I expect, will
 try and take a look closer later today.

 Happy to add, and adding `commit` to this ticket

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52341#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform