[wp-trac] [WordPress Trac] #51941: Unique names for Application Password

WordPress Trac noreply at wordpress.org
Sat Jan 23 14:47:20 UTC 2021


#51941: Unique names for Application Password
-------------------------------------------------+-------------------------
 Reporter:  Boniu91                              |       Owner:  boniu91
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.7
Component:  Application Passwords                |     Version:  5.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |  administration
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 @TimothyBlynJacobs @xkon Updated PR 898 to include the following:

 - Updates schema to include:
     - `minLength` of 3
     - `pattern` to exclude a string with all whitespaces (empty string)
 - `sanitize_text_field( $args['name'] )` when creating a new password
 - Adds HTTP 409 for `WP_Error` unique name
 - Adds HTTP 400 for `WP_Error` empty name
 - Adds test cases for changes

 Ready for your code review. Also adding gifs to show before and after for
 testing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51941#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list