[wp-trac] [WordPress Trac] #51812: Update jQuery step three

WordPress Trac noreply at wordpress.org
Sat Jan 23 12:04:35 UTC 2021


#51812: Update jQuery step three
-------------------------------------------------+-------------------------
 Reporter:  azaozz                               |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.7
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early needs-testing        |     Focuses:  javascript
  needs-dev-note needs-testing-info              |
-------------------------------------------------+-------------------------

Comment (by Clorith):

 @hellofromTonya great question! So this is a bit of an "oddball" to track,
 since it requires checking for JavaScript notices or errors, but there's a
 few ways to do this.

 One way is actually to use the [https://wordpress.org/plugins/enable-
 jquery-migrate-helper/ Enable jQuery Migrate Helper] plugin, by visiting
 its settings (found under `Tools > jQuery Migrate`), you can enable
 deprecation warnings and logging for WordPress 5.6 or newer, this is great
 for non-technical users to test and look for warnings around wp-admin, as
 it will print them on-screen for the user.

 If not, using the JavaScript console of your browser is the more technical
 approach (I mention this second, as not everyone is comfortable in these
 interfaces. There's a [https://wordpress.org/support/article/using-your-
 browser-to-diagnose-javascript-errors/#step-3-diagnosis support article on
 diagnosing JavaScript errors] which covers how to open and use these.

 Now for the actual testing it self, this is kind of wide. One literally
 has to visit pages in the WordPress backend, and use features, and see if
 any warnings show up.

 The expected behavior is that nothing should have changed form before and
 after the patch in features or visuals, only that no warnings should be
 created in the JavaScript console/plugin mentioned above.

 @joyously That's because it is calculating a pixel offset based on a
 percentage, and a warning is now thrown when using offsets without
 defining the unit as well.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51812#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list