[wp-trac] [WordPress Trac] #52327: Requested updates to the PHP Update Alert

WordPress Trac noreply at wordpress.org
Sat Jan 23 11:51:32 UTC 2021


#52327: Requested updates to the PHP Update Alert
--------------------------+-----------------------
 Reporter:  chanthaboune  |       Owner:  audrasjb
     Type:  defect (bug)  |      Status:  accepted
 Priority:  high          |   Milestone:  5.6.1
Component:  Site Health   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------

Comment (by Clorith):

 Thanks for the patch @audrasjb!

 I've got some quick feedback here on the copy.

 The firsts string now reads
 > PHP is the programming language we use to build and maintain WordPress.

 This part of the text should ideally not be changed, as the use of `we` is
 ambiguous, and was intentionally not used for that reason (I see the
 dashboard widget somehow snuck it in though, so changing that to also read
 `languages used to build` in both places seems reasonable).

 The first message inside the dashboard widget is patched to read
 > Your site is running an outdated version of PHP (%s), which requires an
 update.

 This should perhaps also be more aligned with recommendation over required
 if that's the desired outcome here, for example:
 > Your site is running an outdated version of PHP (%s), and should be
 updated.

 I'm not entirely sure if we should remove the conditional message
 separating between `secure` and `outdated`, we are doing a bears service
 (is that an English term? I'm not sure), by tiptoeing around releases that
 no longer receive security updates. Some hosts may patch them internally,
 but for every well-services host, there's a dozen ones that do not have
 routines for that, and presuming everyone does their own patching does not
 help the end user here I feel.

 Erring on the side of "some hosts may not be insecure, even if the PHP
 versions they offer are no longer receiving security updates, but many may
 be" still feels right to me here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52327#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list