[wp-trac] [WordPress Trac] #52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)

WordPress Trac noreply at wordpress.org
Fri Jan 22 15:10:56 UTC 2021


#52341: Upgrade old branches to run on NodeJS LTS (currently 14.x)
-------------------------------------+-----------------------
 Reporter:  desrosj                  |       Owner:  desrosj
     Type:  task (blessed)           |      Status:  assigned
 Priority:  high                     |   Milestone:  5.7
Component:  Build/Test Tools         |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:
-------------------------------------+-----------------------
Changes (by desrosj):

 * keywords:  needs-testing has-patch has-unit-tests => needs-testing has-
     patch


Comment:

 For the images, I did run `precommit:images` and committed the changes in
 https://github.com/WordPress/wordpress-
 develop/pull/885/commits/fab68cdac95ef3c9f07f2c93e3516d9a4d514d9a for the
 5.5 branch.

 It looks like there is one image being "removed", but it's still
 technically there. The `imagemin` script just reduced it enough to be
 considered a 100% change in size.

 I was talking the ticket over with @dd32 yesterday on Slack, and we were
 discussing the number of files being changed in each branch. We should try
 to limit this number as best we can. For the images, it's important that
 the `grunt precommit:images` script works, but including the images
 changed for each branch is not necessary for this process. I'm going to
 remove the image changes from each branch.

 Another item to note that I briefly touched on in the PR descriptions but
 is worth elaborating on. Some dependencies were updated to versions that
 work on NodeJS 14.x, but not to their latest versions. This was most
 common for Webpack aand related packages. I did not update Webpack tooling
 across branches. The version of Webpack used in a branch remained the
 same. Because related packages usually drop support for older versions of
 Webpack in major versions, this results in a handful of those dependencies
 being up to date within a major version range, but not 100% up to date.
 This only affects WP branches >= 5.0.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52341#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list