[wp-trac] [WordPress Trac] #52257: Twenty Twenty-One:Transparent png logo isn’t visible on focus

[WordPress Trac]

#52257: Twenty Twenty-One:Transparent png logo isn’t visible on focus
-------------------------------------+---------------------
 Reporter:  bduclos                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.7
Component:  Bundled Theme            |     Version:  5.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  css
-------------------------------------+---------------------
Changes (by poena):

 * keywords:   => has-patch needs-testing
 * focuses:   => css
 * version:   => 5.6
 * milestone:  Awaiting Review => 5.7


Comment:

 This patch removes custom-logo-link styles from
 sass/06-components/header.scss.
 (This also makes sense because the logo is available both in the site
 header and site footer.)

 It adds {{{background:none}}} to the custom-logo-link when it is focused,
 both in the default color scheme and in dark mode.

 I am not happy with the duplication in assets\sass\style-dark-mode.scss
 where the focus style is added both to regular links and .meta-nav, this
 could be improved.
 {{{
 .site a:focus:not(.wp-block-button__link):not(.wp-block-file__button),
 .site a:focus:not(.wp-block-button__link):not(.wp-block-file__button)
 .meta-nav {
         background: #000;
         color: #fff;
         text-decoration: none;

         &.custom-logo-link {
                 &:focus {
                         background: none;
                 }
         }
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52257#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform