[wp-trac] [WordPress Trac] #52287: Twenty Twenty One: Inline Images displaying on new lines (as display: block)

WordPress Trac noreply at wordpress.org
Mon Jan 18 10:41:20 UTC 2021


#52287: Twenty Twenty One: Inline Images displaying on new lines (as display:
block)
--------------------------------------+---------------------
 Reporter:  talldanwp                 |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  5.7
Component:  Bundled Theme             |     Version:  5.6
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  css
--------------------------------------+---------------------

Comment (by poena):

 Hi!
 I have tested the pull request. I did not see any side effects except the
 following:

 There is a style in the image block file that affects all images, not only
 the block: [https://github.com/WordPress/wordpress-develop/blob/master/src
 /wp-
 content/themes/twentytwentyone/assets/sass/05-blocks/image/_style.scss#L41
 sass/05-blocks/image/_style.scss#L41]

 This is duplicating the height and the max width that is already added in
 the sass/04-elements/media.scss file,
 and it is adding a {{{vertical-align:middle}}} to the images on the front.
 Because of the vertical alignment, the inline images do not look the same
 in the editor and front when the PR is applied.

 I do not know the reason why the vertical alignment was included, further
 testing is needed to see if removing it has any side effects.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52287#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list