[wp-trac] [WordPress Trac] #25473: wp_text_diff creates wrong number of columns if title arguments are set

[WordPress Trac]

#25473: wp_text_diff creates wrong number of columns if title arguments are set
-------------------------------------------------+-------------------------
 Reporter:  joedolson                            |       Owner:  joedolson
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.7
Component:  Revisions                            |     Version:  3.6.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-design-feedback      |     Focuses:
  needs-design needs-screenshots                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by joedolson):

 Added patch covers the bare minimum to move this forward:

 1) Fix structural problems in `wp_text_diff` and
 `WP_Text_Diff_Renderer_Table`
 2) Call title_left and title_right arguments in revisions to add column
 headings.

 Adding the column headings is helpful for understanding that screen,
 although this is a very minimal implementation. That still leaves some
 design requirements for this tickets, but can be dropped to be handled in
 #52303 if we can't determine that.

 Making the structural changes eliminates the empty column space between
 the removals/additions columns. Personally, I don't see a problem with
 just not having that space; but this should also get a design look.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/25473#comment:64>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform