[wp-trac] [WordPress Trac] #51865: Add filter to `wp_image_src_get_dimensions`
WordPress Trac
noreply at wordpress.org
Thu Jan 14 17:57:16 UTC 2021
#51865: Add filter to `wp_image_src_get_dimensions`
-------------------------------------------------+-------------------------
Reporter: joemcgill | Owner: joemcgill
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.7
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion needs-unit- | Focuses:
tests needs-dev-note |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):
* keywords: has-patch 2nd-opinion needs-unit-tests => has-patch 2nd-
opinion needs-unit-tests needs-dev-note
Comment:
❓ Does this ticket still require `2nd-opinion`?
Adding `needs-dev-note` to include in Misc Dev Note, as this patch adds a
new filter.
Adding notes from Core Scrub:
Per Sergey:
>It seems like the `wp_basename()` change should probably be added
separately from the filter and get its own tests.
>
>I think new filters don't generally require unit tests, but if the
function doesn't have any, might be a good idea to add some while we're at
it
Per Joe:
>This makes sense to me. I'll review and open a separate ticket for the
`wp_basename()` change.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51865#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list