[wp-trac] [WordPress Trac] #51976: Core update footer displays incorrect message when on current release -- sometimes

WordPress Trac noreply at wordpress.org
Tue Jan 12 00:07:35 UTC 2021


#51976: Core update footer displays incorrect message when on current release --
sometimes
---------------------------------------+-----------------------
 Reporter:  afragen                    |       Owner:  afragen
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  5.7
Component:  Upgrade/Install            |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui
---------------------------------------+-----------------------

Comment (by afragen):

 Replying to [comment:9 audrasjb]:
 > Hi @afragen, thank you for putting this patch together,
 >
 > I see a small i18n issue here:
 > {{{
 > /* translators: s: URL to WordPress Updates screen. */
 > $stay_updated = sprintf( __( 'Please <a href="%s">stay updated</a>.' ),
 network_admin_url( 'update-core.php' ) );
 > $msg          = $is_development_version ? $msg . ' ' .
 $stay_updated : $msg;
 > }}}
 >
 > Indeed, RTL Locales may need to control the order of the displayed
 message. Using `sprintf` would allow them to switch the content of the
 `$msg` and `$stay_updated` strings 🌎😎

 Updated in https://github.com/WordPress/wordpress-develop/pull/866

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51976#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list