[wp-trac] [WordPress Trac] #42421: Move "Filter by" strings into labels arrays of registrations

[WordPress Trac]

#42421: Move "Filter by" strings into labels arrays of registrations
--------------------------------------+-----------------------------
 Reporter:  johnjamesjacoby           |       Owner:  SergeyBiryukov
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.7
Component:  Administration            |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  administration
--------------------------------------+-----------------------------
Changes (by audrasjb):

 * keywords:  good-first-bug has-patch needs-testing dev-feedback => good-
     first-bug has-patch


Comment:

 Hi,
 I added a small refresh above. Indeed, the patch was not applying cleanly
 against Trunk.
 Plus, I added a small PHP fix on `src/wp-admin/includes/class-wp-list-
 table.php`:
 {{{
 <label for="filter-by-date" class="screen-reader-text"><?php
 get_post_type_object( $post_type )->labels->filter_by_date; ?></label>
 }}}
 was not displaying anything. I added the necessary `echo`.

 I tested the patch the patch and I didn't noticed any change on the
 "Filter by" screen reader text, so I guess we're good to go.

 Cheers,
 Jb

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42421#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform